Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zombie gamemode semi rework #2194

Merged
merged 3 commits into from
Nov 26, 2024
Merged

zombie gamemode semi rework #2194

merged 3 commits into from
Nov 26, 2024
+122 −4

Conversation

deltanedas
Copy link
Member

About the PR

we have revs at home

  • IIs get syndie radio implants to communicate with eachother and form a plan
  • once the event starts, you have to wait 5 minutes before being able to zombify.
    every single person whos played zombies knows of the random musician turning in med while you tried to do a cool plan with other IIs, now you are forced to communicate!
  • changes the flavortext to be more of a bioterrorist than someone who happened to show up to work infected with romerol, why would they suddenly want to kill people instead of getting help / isolating? since it says syndicate sponsored the radio implant makes sense
  • if sec overhears the random group of people chanting DEATH TO NANOTRASEN! in maints before the delay ends they can kill/gib/cremate/etc the body and it wont get to become a zombie :trollface:

this only affects the zombie gamemode and the admin antag control, the event is still relatively disorganized

Why / Balance

zombies is one of the worst gamemodes, this should make it better for everyone (even the crew get a bit more time to have a normal shift instead of instant med biting -> evac)

Technical details

add DelayedRuleComponent for adding the zombie components after a delay

Media

it real

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

no

Changelog
🆑

  • tweak: Initial Infecteds now get radio implants to communicate thanks to the Syndicate.
  • tweak: Initial Infecteds now have to wait 5 minutes before they can turn, form a plan!

@deltanedas deltanedas requested review from a team as code owners November 14, 2024 18:04
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Nov 14, 2024
@Avalon-Proto
Copy link
Contributor

Now this is how to do a zombie mode

@ThataKat
Copy link
Contributor

Unfortunate to lose the "sick and doesn't realize" rp potential but that hardly happened anyways. This seems like a good change to me

@deltanedas
Copy link
Member Author

you can still do that for the survival zombies since theres no syndicate nature to it

MilonPL
MilonPL suggested changes Nov 14, 2024
View reviewed changes
Content.Server/DeltaV/GameTicking/Rules/DelayedRuleSystem.cs Outdated
if (!TryComp<MindComponent>(mindId, out var mind) || !TryGetEntity(mind.OriginalOwnedEntity, out var mob))
continue;

var uid = mob!.Value; // amazing language
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't need a nullable warning suppression, .Value checks for null anyways

@Unkn0wnGh0st333
Copy link
Contributor

make it lore wise that IIs are suicide operatives from gorlex (or something) with an engineered version of romerol that's slower and can activate on command made by interdyne.

@deltanedas
Copy link
Member Author

they are already syndicate affiliated and IIs have always been able to trigger zombification with the action

@Unkn0wnGh0st333
Copy link
Contributor

they are already syndicate affiliated and IIs have always been able to trigger zombification with the action

Loooore wise, the important stuff is always in the details... or maybe I'm just one of those nerds that looks to deep into item descriptions.

@MilonPL MilonPL added S: Awaiting Changes Do not merge due to requested changes and removed S: Needs Review labels Nov 17, 2024
@Avalon-Proto
Copy link
Contributor

Soooo whens this gonna be done

@deltanedas
Copy link
Member Author

still waiting for admin approval

@therealDLondon
Copy link
Member

still waiting for admin approval

You have it. Lets see how this rolls

@github-actions github-actions bot added the size/M 64-255 lines label Nov 26, 2024
@deltanedas deltanedas merged commit 921a0e2 into DeltaV-Station:master Nov 26, 2024
11 of 12 checks passed
@deltanedas deltanedas deleted the zombie-ops branch November 26, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilonPL MilonPL MilonPL approved these changes

@therealDLondon therealDLondon Awaiting requested review from therealDLondon

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Awaiting Changes Do not merge due to requested changes size/M 64-255 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deltanedas @Avalon-Proto @ThataKat @Unkn0wnGh0st333 @therealDLondon @MilonPL